Eip 5559 support - Githubissues

ensdomains / evmgateway

This repository implements a generic CCIP-Read gateway for fetching state proofs of data on other EVM chains. The intended use is for contracts on L1 to be able to fetch and verify data from contracts on L2 in a read context.

MIT License

128 stars 28 forks source link

Eip 5559 support #34

Closed makoto closed 4 months ago

makoto commented 6 months ago

Changes

Add StorageHandledByL2
Change metadata function to only return graphqlUrl `

Open items

Should it only support setAddress or other functions like setContenthash and setText? = I personally think supporting setAddress is enough because there is no function specific info in the StorageHandledByL2 error
Should setAddress be view function or transaction? = I made it as a view function as people shouldn't be sending transaction

makoto commented 6 months ago

Shouldn't we hang fire on this until we have a finished spec for the updated 5559? I can put this back to draft for now but is the current discussion likely to change the format of error StorageHandledByL2

Arachnid commented 6 months ago

Shouldn't we hang fire on this until we have a finished spec for the updated 5559? I can put this back to draft for now but is the current discussion likely to change the format of error StorageHandledByL2

Yes - there's an open conversation about what control the contract should have over the L2 calldata.

Chomtana commented 5 months ago

Would like to know if any libraries adopted EIP-5559?

makoto commented 5 months ago

@Chomtana there is a reference implementation created by the author of EIP-5559 during Eth Sanfrancisco a couple of years ago https://ethglobal.com/showcase/trustless-l2-ens-registry-rollup-solution-429qs . In terms of the library support, we don't expect large adoption as most library only support read only ENS features

Chomtana commented 5 months ago

I think we should also implement standard resolver interfaces (IAddrResolver, IAddressResolver, ITextResolver, and IContentHashResolver) in L1Resolver.sol. At least the ENS official UI needs them.

I have implemented them at: https://github.com/ensdomains/evmgateway/pull/37