ensdomains / subdomain-registrar

A registrar that sells subdomains to users on behalf of their owners
BSD 2-Clause "Simplified" License
185 stars 166 forks source link

Improve UI styling #4

Open Arachnid opened 6 years ago

Cygnusfear commented 6 years ago

https://github.com/Cygnusfear/subdomain-registrar

I did a first update to the UI styling; any feedback would be appreciated.

Todo:

Arachnid commented 6 years ago

This looks fantastic! Feel free to send me a PR whenever you think it's ready. A few minor comments:

Cygnusfear commented 6 years ago

Awesome, thanks!

It should really say "Turn your address 0x..." instead of "Turn your public key 0x..."

I see, I didn't know it was only the last 20 bytes of a hash of the public key. The idea was to add a bit of inline education, looks like the joke is on me B)

If it can't load accounts from web3, it says "Turn your public key undefined..."

I have this fixed in an upcoming commit

I really like the new listing view, but I still think it would be a better UX to move the unavailable names to the end of the list.

I had the list sorted alphabetically but JQuery unbinds the .click event, so this kind of slipped through the cracks along with sorting

So currently the code is messy. Ideally I imagine a node package that contains all the ENS now functions (including reverse lookup, which is necessary for showing the user the currently owned domain names) and doing the layout in react. The package could be adopted by wallet providers or they could redirect to ENS now for users to optionally register an easy name for their address.

I suggest this as I am interested in further promoting ENS (now and regular) adoption, both from the perspective of security and metadata (currently Etherscan has a lot of metadata that is inaccessible and centralized).

Arachnid commented 6 years ago

Yes, that sounds like a good idea. I should add that there is a major rewrite by @jefflau currently in the planning stages that aims to merge now.ens.domains, registrar.ens.domains and manager.ens.domains into a single app.

With that in mind, an NPM module would likely be very useful, but extensive UI work may end up being wasted (but your work so far looks great, and I'd love to see it replace the current interface in the interim).