Closed ToxicDragon closed 3 years ago
Its a known issue, I plan to fix it the same way Akira does by forcing the app to use the elementary theme.
The issue seems to have been fixed when I tested it. @ToxicDragon Can you please test this bundle and confirm that its okay on your end too?
https://api.github.com/repos/SubhadeepJasu/Ensembles/actions/artifacts/89219391/zip
Damn looks like github isn't allowing me to upload the flatpak bundle
Let me know if you are not able to access the artifacts from this pull request https://github.com/SubhadeepJasu/Ensembles/pull/22/checks . In that case I'll make another release.
@SubhadeepJasu Would it be possible for you to provide "Main"/"Alpha" Build versions directly via the appcenter flatpakrepo? Because I installed the app via the existing flatpakrepo and it would be convenient to have an "apha" source for this aswell.
If not possible, I'll try to test your provided bundle.
Not without releasing it. The alpha is released on the main branch. And I need to find a little more about having different sources.
Ok, I'm gonna release this in appcenter. Hopefully the issue is fixed. Fingers crossed.
https://github.com/SubhadeepJasu/Ensembles/releases/tag/v0.0.13 Has the latest fixes. It will be while before this appears on appcenter.
https://github.com/SubhadeepJasu/Ensembles/releases/tag/v0.0.13 Has the latest fixes. It will be while before this appears on appcenter.
I can confirm that this version respects the theming (apparently?) correctly (see the picture below). However, when switching to the system's light theme, the application does a) not switch to the light theme on the fly (Gnome System Apps do) and b) does not switch to light theme at all, even after restarting the app. But maybe a) is expected behaviour for flatpak apps and/or b) is also dependent on the themes available to flatpak OR the application's code only supports dark mode? What do you think @SubhadeepJasu ?
Additionally, it is now possible to resize the window. This was at least not possible horizontally in the previous build. Therefore, the keys of the keyboard do not look too wide anymore.
Update: On second thought, the application's theme resembles - as noted by @SubhadeepJasu - elementary's theme. However it is interesting that only the dark theme is used, not the light one.
Its only designed around a dark theme. That's just how it is. The stylesheet doesn't support any light background colors. Apart from that I am still seeing a few visual issues in the screenshot. The app layout still needs a lot of work to show the controls properly.
Alright, then most visual parts seem to be fine! I mean there some quirks here and there, see the comparison (e.g. the control in the top left corner are truncated a bit).
Original image (elementry OS):
0.0.13 on Gnome Shell (41):
But in general it looks quite good now!
Yeah those visual issues are what I was talking about. Okay, we can close this issue, I'll make a new issue to track the visual quirks.
Thanks for bringing this up!
Sounds good! Thank you for your quick responses and bug fixing; I'm overwhelmed! Really nice application!
Hmm, I'm running into this issue! On Arch Linux, with gnome-shell 41.3 and the arc-gtk-theme installed:
@SubhadeepJasu: Maybe I missed a dependency in my AUR package: does this list look right to you?
Hey! Thanks for putting it in aur. In the list I would suggest also having elementary style sheet. Without that the app isn't gonna render correctly.
Edit: Also the app is still gtk 3 based. It may give errors. And I would also suggest having the lv2 packages, lilv, stratom, etc.
Alright, I think gtk-theme-elementary provides the elementary style sheet on Arch. It renders in dark mode now but still doesn't use the system theme. granite-demo
appears to work fine, so is that on this end or am I missing something else?
I've added as optional dependencies gtk-theme-elementary
, portmidi
(previously required), lv2
, lilv
(serd
, sord
, and sratom
are dependencies), and suil
, which I think should be all the lv2 packages. What does Ensembles use suil
for? I put in brief descriptions for the rest, but couldn't quite figure that one out.
That's okay. Ensembles is designed to use only the elementary theme and then add modifications on top of that. It won't use system them by design, plus it will only use dark theme, that's by design. It's a dark theme app.
It uses suil for rendering gtk ui for lv2 plugins, well that's what its supposed to do, but someone just told me that suil doens't yet support gtk 3 or gtk 4 yet, so that feature is dead in the water.
Hi there,
congratulations to the wonderful application!
I just installed the app via flatpak on Gnome 41 (Ubuntu) and started it. However, the theming seems to be using the gnome themes and looks kind of broken aswell (see screenshot).
Additionally, here is the log output when running the app from command line: