search

ensenso / ros_driver

Official ROS driver for Ensenso stereo cameras.
http://wiki.ros.org/ensenso_driver
BSD 3-Clause "New" or "Revised" License
29 stars 25 forks source link

Fixed undefined behavior in VirtualObjectMarkerPublisher #102

Closed jornb closed 1 year ago

jornb commented 1 year ago

The input arguments were captured by reference, then used in a thread. It could happen that by the time the thread started, the references were invalidated.

Fixed by capturing by value instead.

jornb commented 1 year ago

FYI @erblinium

erblinium commented 1 year ago

@benthie New PR for review =)

jornb commented 1 year ago

Thanks for the review. I think this PR can be closed in favor of #103. That PR incorporates changes requested by @benthie.