search

ensenso / ros_driver

Official ROS driver for Ensenso stereo cameras.
http://wiki.ros.org/ensenso_driver
BSD 3-Clause "New" or "Revised" License
28 stars 25 forks source link

Feat/add calibration plates #112

Open erblinium opened 1 year ago

erblinium commented 1 year ago

Add parsing of calibration plates in virtual_object_handler

benthie commented 10 months ago

Hi @erblinium,

thanks for the contribution. Being able to also publish calibration patterns sounds like a very good idea. Right now the code does not satisfy the code checker yet. And your changes contain a few unwanted indentation changes which makes it hard to add a review via GitHub.

You could try to configure your IDE such that it automatically uses the provided .clang-format file in the repository to format your code when saving a file. By doing so you could be sure that there will be way less issues with the code checker.

Looking forward to add the review as soon as the code checker is happy.

Kind regards Benny