search

ensenso / ros_driver

Official ROS driver for Ensenso stereo cameras.
http://wiki.ros.org/ensenso_driver
BSD 3-Clause "New" or "Revised" License
29 stars 25 forks source link

Line-ending issue in camera.cpp? #33

Closed gavanderhoorn closed 4 years ago

gavanderhoorn commented 4 years ago

Not sure whether it was intentional, but c549c808 seems to have done some bad things with the line-endings in ensenso_camera/src/camera.cpp.

gavanderhoorn commented 4 years ago

Related: would there be interest in setting up some form of CI in this repository?

yguenduez commented 4 years ago

Thanks for the hint! The line ending was not intended. And

interest in setting up some form of CI in this repository?

Of Couse. This is probably the next thing to do.

gavanderhoorn commented 4 years ago

interest in setting up some form of CI in this repository?

Of Couse. This is probably the next thing to do.

Could I suggest using industrial_ci for this?

The only 'difficult' bit would be the sdk, but seeing as you are maintaining that yourself, it should be more than possible to configure things such that it can be installed into the container before performing the rest of the build.

If using industrial_ci, I'd recommend using the master branch, as it's received quite a bit of attention since legacy.

yguenduez commented 4 years ago

Thanks! I will have definitely have a look into it. And .. ..how do you respond that fast? :)

gavanderhoorn commented 4 years ago

Github has had email notifications for quite a while now ;)

gavanderhoorn commented 4 years ago

Perhaps @ipa-mdl could comment on what the best/most efficient way would be to get a non-apt/non-ROS/non-rosdeppable pkg dependency injected into an industrial_ci Travis setup.

gavanderhoorn commented 4 years ago

See #34 for a proposed CI configuration.