ensenso / ros_driver

Official ROS driver for Ensenso stereo cameras.
http://wiki.ros.org/ensenso_driver
BSD 3-Clause "New" or "Revised" License
28 stars 25 forks source link

Fix boost/std shared pointers #92

Closed andiburaschi closed 1 year ago

andiburaschi commented 1 year ago

As of Oct22, there are compilation errors around the use of boost shared pointers when pcl expects STL ones. Therefore:

benthie commented 1 year ago

Hi Andres,

thank you very much for contributing, we always appreciate the effort of other ROS users to improve our camera driver.

I had a look into the changes you made. Since we currently released v2.0.0 (and v1.7.1), there are some changes we made that affect the locations you modified in the code.

Due to the ROS1-ROS2 compatibility layer we introduced, the point clouds are now handled as std::unique_ptr in our code before they are converted to boost::shared_ptr when being published in ROS1.

Regarding the publishing: As in the ROS Publisher API, publishing as boost::shared_ptr is fine and allows for "fast intra-process message-passing".

Kind regards Benny