ensignlee / ssbook

ssbook
5 stars 3 forks source link

Add back the "view" option where you could see details about each game #38

Closed ensignlee closed 13 years ago

ensignlee commented 13 years ago

Remember that debug screen you had where you could look up the score of the game and what not? I actually think something like that would be cool to have on the final site.

If I was curious what the score was for a game, I wouldn't have to leave SharpBetTracker to do it.

ensignlee commented 13 years ago

Now that I can't see it anymore, I forgot how that debug screen works.

A box score like how ESPN shows it would be awesome, showing the score by quarter/period, etc. Is that possible?

ensignlee commented 13 years ago

I saw that you added the "view" button back. When I was clicking around, I noticed it had a bunch of wrong games on it. That might be related to our whole primary key mess?

The games seem to still be graded correctly though?

camerondavison commented 13 years ago

yea, looks like a grabbed the wrong id. I was using the bet id instead of the score id. I am leaving this open until I actually put work into the page itself. what do you want it to look like any ideas?

ensignlee commented 13 years ago

A normal box score would work.

camerondavison commented 13 years ago

make view page look like a box score. closed by 1da2251d2d62cf5c36a9d3ac1f5656f57464d002

ensignlee commented 13 years ago

I guess I should have been more specific when I said box score.

For football and basketball: quarter by quarter score

For baseball, inning by inning score

For hockey, period by period (there are three of them) score.

camerondavison commented 13 years ago

I do not have any of this information. I right now am only keeping the first half and total score for each sport that it is appropriate to have. Do you really want me to keep all that information around to show people? If so I can, but just know it is a ton of more work and parsing of the page that I am not currently doing.

ensignlee commented 13 years ago

ORLY? Interesting. I thought you were parsing the quarter scores in from ESPN. My mistake.

Hmm, in that case, let me rethink this.

ensignlee commented 13 years ago

Okay, let's go back to what it used to look like. Until we have time to parse out the quarters and innings and what not, I think we should not show it to the users.

That being said, I still want to see it to debug, so can we keep it up until the site goes live?

camerondavison commented 13 years ago

thats fine with me.