Auto-buyer received major update; need to merge

meishuu commented 9 years ago

I've just done a major update to the standalone version but it requires another global variable to maintain persistence and is probably all-around messy to toggle all functionality on/off at will.

I'd be willing to merge this myself but I'm super sleepy. If someone else can do it, please feel free and say so, otherwise I'll work on it once I wake up.

Summary of changes:

Added setting to enable buying abilities; off by default
Fixed necessaryUpgrade() computing costs incorrectly
bestDamageUpgrade() now accounts for effects of crits and elementals in all cases (fixes #35)
bestDamageUpgrade() also checks locked click damage upgrades to see if unlocking them and getting the first upgrade is worth it
timeToDie() now only ever updates on new levels or when an upgrade was purchased
If an upgrade purchase fails to go through, we try to force a data refresh before recalculating next item (also fixes script entirely breaking if an upgrade fails to go through)
Successful upgrade purchase, now including manual ones, will force an early re-evaluation of next item, so the timer now only serves to wait until we have enough gold to purchase the queued item (I think)

Someone can probably just pick out the changes relevant to fixing bestDamageUpgrade() for now. Also, I've just now noticed a change to a single element strategy so that could use some fiddling.

ensingm2 commented 9 years ago

"I'd be willing to merge this myself but I'm super sleepy. If someone else can do it, please feel free and say so, otherwise I'll work on it once I wake up."

Same deal. 8:30am here and I forgot to sleep. Going to bed, I'll toy with it if nobody else has when I wake up.

waterfoul commented 9 years ago

I'll start trying this now and send a PR

JimRaynor56 commented 9 years ago

It's going to need another update to account for the new upgrades.

waterfoul commented 9 years ago

Reading through the code I believe it will handle the new upgrades automatically, need to confirm though

ensingm2 commented 9 years ago

Unless I'm mistaken (I only quickly glanced at the update, focusing on my massive inbox right now), the new upgrades need to be added to the gHealthUpgrades & gDamageUpgrades arrays, after which point they will work?

If you could add that, or confirm new upgrades are indeed working, it'd be awesome. Otherwise I'll add them once I get around to figuring out the new ability IDs

ensingm2 commented 9 years ago

Should (Hopefully) work now. Reopen if that's not the case.

ensingm2 / SteamMonsterGameScript

Auto-buyer received major update; need to merge #44