search

ensingm2 / SteamMonsterGameScript

A Javascript automator for the 2015 Summer Steam Monster Minigame
78 stars 29 forks source link

Clean up the UI and fix issue with item use toggleing upgrade button #58

Closed vanZeben closed 9 years ago

vanZeben commented 9 years ago

Moves all the UI elements into the same line and clean up the visual names (No reason to use "Auto" in front of every single function, just redundant and takes up space), also combines SFX and Music into a single sound button...

Also the Item use was toggling the upgrade button

ensingm2 commented 9 years ago

As of https://github.com/ensingm2/SteamMonsterGameScript/commit/7285f29f254df35a33aabe43887bb3ceccc0b041 , The slave script buttons take up the area after the sfx/music buttons. Adding these in as well clutters the bar, And I think it's a good idea to have the button groups separate. Closing this pull request, comment as needed.

vanZeben commented 9 years ago

I was going to say hold off on this one, commited this before I saw you move them up. Working on a better way, but d9b4045 could be pulled in regardless, pure empty space, and integrates the ugly quit button better

ensingm2 commented 9 years ago

As far as pulling in d9b4045, it relies on 7d1d0d0. I can either update the master by hand, or if you want or you can revert 7d1d0d0 and I can merge in this request.

vanZeben commented 9 years ago

Im cleaning it up right now, give me a few minutes :D

vanZeben commented 9 years ago

God its been awhile for me with git... Let me clean this up and ill open a new one

ensingm2 commented 9 years ago

I'm actually almost done fixing it up, no worries

ensingm2 commented 9 years ago

See https://github.com/ensingm2/SteamMonsterGameScript/pull/61