search

ensingm2 / SteamMonsterGameScript

A Javascript automator for the 2015 Summer Steam Monster Minigame
78 stars 29 forks source link

Uncaught ReferenceError: useResurrectBelowLaneAlive is not defined #71

Closed Evanito closed 9 years ago

Evanito commented 9 years ago

As title says, I get this error in console once every few seconds. I have two resurrects.

ensingm2 commented 9 years ago

Oops, changed a variable name and missed a reference to it (Hard to test these things when I don't actually have the item :X). Can you verify it's working as of https://github.com/ensingm2/SteamMonsterGameScript/commit/08d8b59dbce35b77a2830a51fa780801081cd196 ?

Evanito commented 9 years ago

Affirmative, works as expected, even used a resurrect once I refreshed.

xImpulse commented 9 years ago

This is actually more broken for me after this update: https://github.com/ensingm2/SteamMonsterGameScript/commit/08d8b59dbce35b77a2830a51fa780801081cd196 The resurrection ability is being auto-used continuously even if no players are dead in any lane. Before this version, I don't think the ability was auto-used at all.

ensingm2 commented 9 years ago

Fuck me. Yeah you're right, looks like I typo'd and it only used if under the threshold of people were dead, not over. Fixing now (Of course I'm stuck in a 'waiting for players to join' so it'll be a minute or two before I can test).

ensingm2 commented 9 years ago

I think it should be fixed in 6632d11. Can you confirm?

Evanito commented 9 years ago

Im out of resurrects so don't look at me haha

ensingm2 commented 9 years ago

Tested. SEEMS to be working now.

xImpulse commented 9 years ago

Seems to be fixed. Thanks for your awesome script!