ensingm2 / SteamMonsterGameScript

A Javascript automator for the 2015 Summer Steam Monster Minigame
78 stars 29 forks source link

don't adjust crit_percentage for calculations #88

Closed meishuu closed 9 years ago

meishuu commented 9 years ago

The idea to reduce it by base crit_percentage stemmed from me noticing very few crits during a short testing session. I've automated the test and found that it's probably pretty reliable after all.

So we can stop adjusting it, and people with 100-110% crit will be guaranteed to never get elementals.

TODO: crit_percentage may need to be clamped to [0, 1] if the server doesn't already do that for us.

meishuu commented 9 years ago

I'm pretty sure it doesn't clamp so I guess we might as well do it ourselves.