The idea to reduce it by base crit_percentage stemmed from me noticing very few crits during a short testing session. I've automated the test and found that it's probably pretty reliable after all.
So we can stop adjusting it, and people with 100-110% crit will be guaranteed to never get elementals.
TODO: crit_percentage may need to be clamped to [0, 1] if the server doesn't already do that for us.
The idea to reduce it by base
crit_percentage
stemmed from me noticing very few crits during a short testing session. I've automated the test and found that it's probably pretty reliable after all.So we can stop adjusting it, and people with 100-110% crit will be guaranteed to never get elementals.
TODO: crit_percentage may need to be clamped to [0, 1] if the server doesn't already do that for us.