enso-org / dataframes

A library for working with tabular data in Luna.
https://luna-lang.org
MIT License
6 stars 5 forks source link

[packaging] Set binaries to be writeable during patching. #135

Closed mwu-tow closed 5 years ago

mwu-tow commented 5 years ago

This PR:

  1. Moved installBinary and installDependencyTo from Program.Patchelf module to Platform.Linux module. Program modules are intended to contain simple wrappers over program commands. More complex actions involving calling multiple programs do not belong there.

  2. installBinary temporarily changes patched binary file permissions to make it writeable. Even though this is a copy that we own it might be non-writable — this blocks Azure-based CI, as Docker containers are used with non-root user there (and installed libraries are read-only).