It has been reported on Discord that our current error message on Table.read not being able top open/read file is not helpful. Reason is two-fold:
1) the error pretty printing call was missing an argument, so we got error-formetting-error instead of actual error;
2) the actual error wouldn't be helpful anyway -- we ignored the actual error with reading file (that can be caused by wrong permission settings or wrong path), because we expect failure possibility when trying to match proper parser for given file.
Now not being able to read file is a special class of errors that stop the parser-matching routine and allow to give proper diagnostics to the user.
Important Notes
Checklist
Please include the following checklist in your PR:
[ ] The documentation has been updated if necessary.
Pull Request Description
It has been reported on Discord that our current error message on
Table.readnot being able top open/read file is not helpful. Reason is two-fold: 1) the error pretty printing call was missing an argument, so we got error-formetting-error instead of actual error; 2) the actual error wouldn't be helpful anyway -- we ignored the actual error with reading file (that can be caused by wrong permission settings or wrong path), because we expect failure possibility when trying to match proper parser for given file.Now not being able to read file is a special class of errors that stop the parser-matching routine and allow to give proper diagnostics to the user.
Important Notes
Checklist
Please include the following checklist in your PR: