enso-org / dataframes

A library for working with tabular data in Luna.
https://luna-lang.org
MIT License
6 stars 5 forks source link

Windows support & Python bindings refactoring #68

Closed mwu-tow closed 6 years ago

mwu-tow commented 6 years ago

This pull request makes matplotlib, seaborn and sklearn python modules bindings work on Windows. It also refactors the relevant pieces of code, so: 1) it doesn't leak memory 2) it doesn't crash Luna when called with "wrong" arguments 3) Python exceptions are translated to C++ exceptions and C++ exceptions are translated to Luna exceptions — all preserving the original error message from the throw location 4) it is MUCH shorter and simpler

It also adds unit tests that generate PNG plot and regression functions. Also CircleCI image has been updated so the test can succeed.

Notes:

mwu-tow commented 6 years ago

47 should also be connected to this PR.

mwu-tow commented 6 years ago

Going ahead with merge, to be tested by @sylwiabr