search

enso-org / dataframes

A library for working with tabular data in Luna.
https://luna-lang.org
MIT License
6 stars 5 forks source link

Abs method #85

Closed sylwiabr closed 5 years ago

sylwiabr commented 6 years ago

This adds abs method for a LQuery value

mwu-tow commented 6 years ago

The code itself looks good. It'd be great if you added some tests. See https://github.com/luna/Dataframes/blob/master/native_libs/test/Tests.cpp#L381 for example how it was done with negate. The fixture deifiniton is here: https://github.com/luna/Dataframes/blob/master/native_libs/test/Tests.cpp#L279

mwu-tow commented 6 years ago

Also, likely a separate matter, but Luna's built-in types (Int, Real) should get this method as well. The assumption is that LQuery tries to mimic the built-in types interface.

piotrMocz commented 6 years ago

If you're doing a PR, please connect it to an issue (even if it meant creating one just for the sake of being connected to). ZenHub doesn't handle standalone PRs well ;)