Cloud Integrated File Browser Widget

enso-org / enso

Hybrid visual and textual functional programming.

https://enso.org

Apache License 2.0

7.31k stars 318 forks source link

Cloud Integrated File Browser Widget #10167

Open AdRiley opened 1 month ago

AdRiley commented 1 month ago

Data.read has a open from cloud drive option - which gives a similar experience to the cloud drive view allowing you to pick a cloud file and insert it.

farmaazon commented 2 weeks ago

REfinement notes:

Should be designed and refined with cloud team.

PabloBuchu commented 1 week ago

Oh wow.. its much more rich than I thought we want to build. Its basically a mini cloud dashboard preview.. Questions:

I assume drag n drop functionalities (like assigning labels, moving assets) should be disabled? I see "create new label" is this necessary?
Do we need all columns? like share with or the buttons that toggle other types?
Do we need trash/recent/drafts/bookmarks?
Do we need upload /download / create datalink?
Whats read a local file?

If the main reason for file browser is to allow user for searching through the files then maybe its too much?

AdRiley commented 1 week ago

Yes sorry. That is a bad screenshot, but was all I had.

You are right it should be very simple file browser/picker.

PabloBuchu commented 1 week ago

Thanks! I just wanted make sure :)

farmaazon commented 1 week ago

Refinement notes

Let's start with having this as Vue component
Cloud uses TanStack query https://tanstack.com/query/latest/docs/framework/react/typescript#typing-query-options for cloud API; we could use the same library (it has the Vue API), but make sure we're using the same cache (talk with @MrFlashAccount)
- It seems they're in the process of refactoring - work closely with dashboard team.
The projects may be hidden or treated as directories, depending on what's easier to implement.
The missing dashboard icons shall be ported to figma design.

TypeScript | TanStack Query React Docs
React Query is now written in TypeScript to make sure the library and your projects are type-safe! Things to keep in mind:

farmaazon commented 6 days ago

Split off the first part about shared library to #10400