enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.34k stars 323 forks source link

The project name is always accepted, regardless which button I click. #10184

Closed farmaazon closed 3 months ago

farmaazon commented 4 months ago

Discord username

farmaazon

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

Is this a regression?

What issue are you facing?

When I start changing project's name and click (x), the name seems to be accepted.

Expected behaviour

I expect (x) icon to be something for discarding current edit.

How we can reproduce it?

No response

Screenshots or screencasts

Screencast from 2024-06-05 13-24-12.webm

Logs

No response

Enso Version

Version 2024.1.1-rc.2 Build c0612dbd858e7491faebc59c4b1747062692de64 Electron 25.7.0 Chrome 114.0.5735.289 User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) enso/2024.1.1-rc.2 Chrome/114.0.5735.289 Electron/25.7.0 Safari/537.36

Browser or standalone distribution

Standalone distribution (cloud project)

Browser Version or standalone distribution

standaolne

Operating System

Linux

Operating System Version

Garuda

Hardware you are using

No response

MrFlashAccount commented 4 months ago

@somebody1234 I guess it's due to optimistic updates, right?

somebody1234 commented 4 months ago

@MrFlashAccount no, because optimistic updates only happen when sending a request to the backend - and when canceling, of course no backend request is sent.

it may be a race condition or focus issue causing the "submit" action to be triggered instead of the "cancel" action (note that clicking away from the asset counts as accepting the rename)