Change grab cursors; fix some bugs - Githubissues

enso-org / enso

Hybrid visual and textual functional programming.

https://enso.org

Apache License 2.0

7.31k stars 318 forks source link

Change grab cursors; fix some bugs #10215

Closed kazcw closed 3 weeks ago

kazcw commented 1 month ago

Pull Request Description

Change grab cursors:

Node has grab/grabbed icons for only halo and icon.

Fix bugs:

Empty part of top bar no longer blocks mouse events.
JSON viz: Clickable parts of inline elements now use pointer cursor when hovered.
Doc panel breadcrumbs: Icon can be clicked (behavior now consistent with cursor shown).

https://github.com/enso-org/enso/assets/1047859/3e48a6c1-3f43-497f-82ad-eb787e9c9643

Closes #10166.

Important Notes

New global clickable class replaces cursor: pointer; the class can be applied closer to the event handler.
Refactor: Extracted GraphNode output port logic to a new component.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.