enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.31k stars 318 forks source link

Imrpove BG rendering #10219

Closed MrFlashAccount closed 2 weeks ago

MrFlashAccount commented 1 month ago

Pull Request Description

Difference

The difference isn't significant, but noticeable | Before | After | |--------|--------| | ![Before](https://github.com/enso-org/enso/assets/61194245/b35f2ee2-9e9d-4f42-9f0d-fa722373489c) | ![After](https://github.com/enso-org/enso/assets/61194245/a241e1c9-089a-4760-bcfc-133f4d9535c1) |

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

PabloBuchu commented 3 weeks ago

@MrFlashAccount whats keeping us from merging this?

MrFlashAccount commented 3 weeks ago

@MrFlashAccount whats keeping us from merging this?

First of all, it's not urgent 🙂, also I need to test this PR against the redesign once again.

MrFlashAccount commented 3 weeks ago

@somebody1234 I spent some time on refining the background - made it less reddish to better match the design, it still requires some polishing though(we need to replace bg-white/80 with bg-white/90) to match it perfectly. But this can be changed later (we need to merge the redesign first)

Also, I did some refinement in tailwind.css: merged similar declarations, reduced specificity for basic styles

Would you like to take a look?

PabloBuchu commented 2 weeks ago

@MrFlashAccount I know it wasn't urgent but it was hanging for some time so I asked. We have a lot of waiting PRs and I want to clear it in the next couple of days