search

enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.31k stars 318 forks source link

Only Allow Node Adding Gets For JS_Objects in the JSON viz #10246

Open jdunkerley opened 3 weeks ago

jdunkerley commented 3 weeks ago

Alter the JSON Viz, so that we say whether get click through should be enabled in the Libs code.

And then only add the click through support if supported (JS_Object)

farmaazon commented 3 weeks ago

See also discussion at https://github.com/enso-org/enso/issues/9606 - there is a more general solution discussed, where objects may specify how to get an element (by default it could be .to_json.get but JS_Object may specify only .get, and then we may add more specific cases like exact getters of datetime fields etc).

farmaazon commented 3 weeks ago

I chatted with @jdunkerley, and he wants to avoid to_json conversion. But still it's worth leaving an option to allow more cases than JS_Object (like mentioned DateTime, or array of JS_Objects).

enso-bot[bot] commented 3 weeks ago

Martha King reports a new STANDUP for today (2024-06-13):

Progress: investigating json get code and how to identify data type to disable if not JS_Object It should be finished by 2024-06-21.

enso-bot[bot] commented 3 weeks ago

Martha King reports a new STANDUP for today (2024-06-14):

Progress: PR raised adressing comments and investigating failing build It should be finished by 2024-06-21.