enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.34k stars 323 forks source link

Fix various issues on the Dashboard #10256

Closed somebody1234 closed 3 months ago

somebody1234 commented 3 months ago

Pull Request Description

Important Notes

Testing Instructions

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

PabloBuchu commented 3 months ago

| Limit length of PermissionDisplay - if the username of a user with permission is too long, it uses a tooltip instead

  1. How long is too long?

    Screenshot 2024-06-18 at 12 23 04
  2. When dropping a label on directory PATCH request is being send twice (at least on Firefox)

  3. Reload on firefox works selectively (sometimes I need to reload 2 or 3 times or hard reload for dashboard to apear)

  4. Removing labels is not working on Firefox

  5. When I want to drop a file on dashboard I see white box

somebody1234 commented 3 months ago
  1. and 5. addressed, will address the others soon
somebody1234 commented 3 months ago

ok i think 2 and 4 are now addressed as well. for 3 i think i might need more details - what happens when reloading fails, instead of the dashboard appearing? (screenshots and screencasts would be useful)

somebody1234 commented 3 months ago

(@PabloBuchu i guess this PR is ready for re-QA?)

MrFlashAccount commented 3 months ago

QA 1 ❌

  1. UserName/OrgName in the title is wider than it should be. Also, I'm not sure it's a good idea to display a tooltip if the content doesn't overflow(maybe it's due to hardcoded height, told ya to not specify height explicitly) CleanShot 2024-06-20 at 11 55 18
  2. On my account, the Name input in settings is empty: CleanShot 2024-06-20 at 11 59 22
  3. KBD shortcuts are not aligned CleanShot 2024-06-20 at 12 00 16
  4. (Not sure it's related to this PR, can be a separate issue) When I have a long project name and want to rename it, the table resizes and I might misclick on the input and renaming discards(see video attached)

https://github.com/enso-org/enso/assets/61194245/a84ac55c-ef5d-4c58-80f6-9ba8477853b0

  1. (Not sure it's related to this PR, can be a separate issue) We should trigger rename by clicking anywhere on the name field, not only on the text
  2. (Not sure it's related to this PR, can be a separate issue) When I quickly double-click on the name field, renaming doesn't show up.
  3. (This can be a separate issue) Can we also limit the length of labels as well? CleanShot 2024-06-20 at 12 09 03
somebody1234 commented 3 months ago

We should trigger rename by clicking anywhere on the name field, not only on the text

this should already be the case i think

When I quickly double-click on the name field, renaming doesn't show up

double clicking opens the asset (projects are run, directories are toggled).

the mouse shortcut for rename is supposed to be single click + single click - apparently this is the behavior of finder on macos?

will definitely address the other issues though

MrFlashAccount commented 3 months ago

double clicking opens the asset (projects are run, directories are toggled).

Hm, just tried - nothing happend

somebody1234 commented 3 months ago
  1. addressed
  2. addressed
  3. can't repro (after temporarily changing linux modifier keys to icons) - it may be easier for you to fix it?
  4. addressed
  5. N/A (see above)
  6. N/A (see above)
  7. addressed

CRs should be addressed as well

MrFlashAccount commented 3 months ago

QA ✅