Closed somebody1234 closed 3 months ago
| Limit length of PermissionDisplay - if the username of a user with permission is too long, it uses a tooltip instead
How long is too long?
When dropping a label on directory PATCH request is being send twice (at least on Firefox)
Reload on firefox works selectively (sometimes I need to reload 2 or 3 times or hard reload for dashboard to apear)
Removing labels is not working on Firefox
When I want to drop a file on dashboard I see white box
ok i think 2 and 4 are now addressed as well. for 3 i think i might need more details - what happens when reloading fails, instead of the dashboard appearing? (screenshots and screencasts would be useful)
(@PabloBuchu i guess this PR is ready for re-QA?)
QA 1 ❌
https://github.com/enso-org/enso/assets/61194245/a84ac55c-ef5d-4c58-80f6-9ba8477853b0
We should trigger rename by clicking anywhere on the name field, not only on the text
this should already be the case i think
When I quickly double-click on the name field, renaming doesn't show up
double clicking opens the asset (projects are run, directories are toggled).
the mouse shortcut for rename is supposed to be single click + single click - apparently this is the behavior of finder on macos?
will definitely address the other issues though
double clicking opens the asset (projects are run, directories are toggled).
Hm, just tried - nothing happend
CRs should be addressed as well
QA ✅
Pull Request Description
kbd
(aria.Keyboard
) to display keyboard shortcuts, since they should not be displayed in a monospace font.PermissionDisplay
- if the username of a user with permission is too long, it uses a tooltip insteadImportant Notes
Testing Instructions
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Unit tests have been written where possible.