Fix context lock removal

hubertp commented 3 months ago

Pull Request Description

Removal of context lock assumed that one still holds a lock on it. This is no longer the case when using a withContextLock block that correctly manages the resource. This change fixes the IllegalMonitorStateException. Closes #10254.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.

hubertp commented 2 months ago

Tried to address your comment @JaroslavTulach, didn't really see the need for AutoCloseable. If still not good, please feel free to send a patch to this PR

JaroslavTulach commented 2 months ago

If still not good, please feel free to send a patch to this PR

More encapsulation in c8b5111. Feel free to go with or without c8b5111 change.

enso-org / enso

Fix context lock removal #10273

Pull Request Description

Checklist