Fix tooltip display and other refinements across dashboard

enso-org / enso

Hybrid visual and textual functional programming.

https://enso.org

Apache License 2.0

7.31k stars 317 forks source link

Fix tooltip display and other refinements across dashboard #10294

Closed MrFlashAccount closed 2 weeks ago

MrFlashAccount commented 2 weeks ago

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.

MrFlashAccount commented 2 weeks ago

In Figma, the start screen seems more like a separate screen

CleanShot 2024-06-16 at 12 54 05@2x

MrFlashAccount commented 2 weeks ago

might as well remove the closeButton prop from Dialog as well

Let's leave it for now, maybe it makes sense but requires additional refinement

somebody1234 commented 2 weeks ago

note that that's an outdated design - if it were its own page it would not be accessible because it no longer has its own tab. the correct design is present on the "drive" page, as "start with template pop up"

somebody1234 commented 2 weeks ago

you'll need to clone the design to be able to edit the visibility though

MrFlashAccount commented 2 weeks ago

you'll need to clone the design to be able to edit the visibility though

Oh god.

My main disagreement with the floating button located this way is that it messes up the content below:

https://github.com/enso-org/enso/assets/61194245/cc55faa6-d433-4ad0-aeef-84329364b283

And adding a title looks the best at the moment. Designers make pictures, we make interfaces. We must think about how the design works and adapt it.

somebody1234 commented 2 weeks ago

it's trivial to solve by adding a title bar but leaving it blank and without a border in between. and again, having a title makes zero sense here as there is already a larger title.

(another option is to add a clip path that omits just the window buttons but I'm not sure whether that would look good)

MrFlashAccount commented 2 weeks ago

Empty title bar looks ugly.

MrFlashAccount commented 2 weeks ago

https://github.com/enso-org/enso/assets/61194245/96c49396-53d4-4acf-bc99-42ba117b5cbb

Now looks better