Inline modules in `app/ide-desktop/`

somebody1234 commented 1 week ago

Pull Request Description

Remove unnecessary modules
- Remove ts-plugin-namespace-auto-import as it was a workaround to use the non-conventional import * convention
- Remove esbuild-plugin-copy-directories as it is unuse
Inline modules that are only ever used once
- Inline project-manager-shim into gui2 - it is only used during gui2's dev mode
- Inline content-config into client
Flatten app/ide-desktop/lib/ to app/ide-desktop/
Flatten app/ide-desktop/lib/dashboard/ to app/dashboard/

Important Notes

As mentioned above, all remaining modules have been moved up from app/ide-desktop/lib/ to app/ide-desktop/. It's not ideal but I'd rather hold off on moving them anywhere else before we have a consensus on what should go where.
- (That is to say, this may not be the final directory structure - but I figure it's fine to get something done so that hopefully the rest of the restructuring is simpler.)

Code Review Notes

There are a lot of files changed, but the vast majority are renames without changes and hence have no need to be reviewed.
Similarly, there are a lot of lines changed, but for the most part that is unavoidable due to the flattening significantly changing the order of entries in the package.json.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

[x] ~~The documentation has been updated, if necessary.~~
[x] ~~Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.~~
[x] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] ~~Unit tests have been written where possible.~~

farmaazon commented 1 week ago

Flatten app/ide-desktop/lib/ to app/

Well, when the directory structure was designed, I imagined app folder representing not the application but rather all applications:

engine (compiler and maybe project manager)
GUI (a package common for cloud browser and electron package)
ide-desktop - electron package using GUI above

Thence came gui and ide-desktop. Much later on, dashboard landed inside ide-desktop which started breaking the above schema (it should land in GUI instead... but GUI was then in rust). Also, engine never made it to this app folder, because none wanted to spend time on sbt reconfiguring.

But still, I think we should ultimately keep separation between GUI and electron, just for cloud-in-browser sake.

Also, these changes may greatly conflict with @Frizi efforts of migrating to pnpm - a part of moving to Bazel, mostly done as far as I'm aware. I would wait for @Frizi changes to land first, to avoid nasty conflicts. Also, all significant directory restructuring should be consulted with "Bazel" team (@hubertp and @Frizi)

Edit: ok, I think I'm not aware, or misremembered some arrangements, so please ignore the second part.

somebody1234 commented 5 days ago

umm... https://github.com/enso-org/enso/actions/runs/9675920069/job/26694401507#step:7:639

anyone know how to fix project references in TS?

GitHub
Inline modules in `app/ide-desktop/` · enso-org/enso@0c52059
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

somebody1234 commented 4 days ago

Pinging @Frizi for visibility

somebody1234 commented 2 days ago

@jdunkerley i think we need the approval of someone from libs because dataLinkSchema.json is being moved.

also the CODEOWNERS file has been updated and that one should probably be reviewed too

somebody1234 commented 2 days ago

@farmaazon @Frizi either of you happen to know why lint CI is saying this? https://github.com/enso-org/enso/actions/runs/9714248920/job/26812883079?pr=10305#step:7:200

 INFO ide_ci::program::command: npm⚠️ npm ERR! code 127
 INFO ide_ci::program::command: npm⚠️ npm ERR! path /runner/_work/enso/enso/app/gui2
 INFO ide_ci::program::command: npm⚠️ npm ERR! command failed
 INFO ide_ci::program::command: npm⚠️ npm ERR! command sh -c playwright install
 INFO ide_ci::program::command: npm⚠️ npm ERR! sh: 1: playwright: not found

i also got it while running locally but not sure what could possibly cause this...

GitHub
Inline modules in `app/ide-desktop/` · enso-org/enso@cc9493e
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

enso-org / enso