The current implementation contains logic that should enable us to make some backward compatibility config changes.
At the same time, the logic is tightly integrated with circe's JSON library, which we want to eventually to get rid off.
Rather than trying to keep it somehow around and maintain via some hacks this PR proposes to ditch that logic completely as we currently have no use-case for such scenarios.
As a result, classes modelling YAML configs now don't have the extra fields and there is 1:1 correspondence.
Performance has also improved although that wasn't the main objective, yet. Follow up PR will attempt to replace circe-yaml with snakeyaml directly.
In preparation for #9113. Note that the dependency upgrade is necessary because it brings latest available snakeyaml (as part of circe-yaml).
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Pull Request Description
The current implementation contains logic that should enable us to make some backward compatibility config changes. At the same time, the logic is tightly integrated with circe's JSON library, which we want to eventually to get rid off. Rather than trying to keep it somehow around and maintain via some hacks this PR proposes to ditch that logic completely as we currently have no use-case for such scenarios.
As a result, classes modelling YAML configs now don't have the extra fields and there is 1:1 correspondence.
Performance has also improved although that wasn't the main objective, yet. Follow up PR will attempt to replace
circe-yamlwithsnakeyamldirectly.In preparation for #9113. Note that the dependency upgrade is necessary because it brings latest available
snakeyaml(as part ofcirce-yaml).Checklist
Please ensure that the following checklist has been satisfied before submitting the PR: