Replace `Button variant="custom"` with appropriate variant whenever possible - Githubissues

enso-org / enso

Hybrid visual and textual functional programming.

https://enso.org

Apache License 2.0

7.31k stars 317 forks source link

Replace `Button variant="custom"` with appropriate variant whenever possible #10315

Open somebody1234 opened 1 week ago

somebody1234 commented 1 week ago

Pull Request Description

Buttons were switched to variant="custom" as low hanging fruit in order to remove UnstyledButton (which was strictly inferior UX wise).

Switch buttons to use variant="submit" or variant="cancel" as appropriate
Replace both ButtonBar and HorizontalMenuBar with ButtonGroup

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

[x] ~~The documentation has been updated, if necessary.~~
[x] ~~Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.~~
[x] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] ~~Unit tests have been written where possible.~~

somebody1234 commented 2 days ago

@MrFlashAccount code review would be appreciated on this one, unless you think we should close this and instead slowly migrate them away