Verify ./runner executable on all supported OSes

enso-org / enso

Hybrid visual and textual functional programming.

https://enso.org

Apache License 2.0

7.3k stars 317 forks source link

Verify ./runner executable on all supported OSes #10329

Closed JaroslavTulach closed 3 days ago

JaroslavTulach commented 1 week ago

Pull Request Description

Follow up to #10126. If we want to use the ./runner executable as the default launcher, we need to make sure it builds and runs on all operating systems we support.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

[x] All code follows the style guides
[x] All CI checks continue to pass

JaroslavTulach commented 1 week ago

I guess all the Base_Tests continue to run without any error.

JaroslavTulach commented 1 week ago

We seem to have space in path issue on Mac: https://github.com/enso-org/enso/actions/runs/9610005652/job/26505581593?pr=10328#step:7:1546
we cannot execute smalljdk.sh!? on windows: https://github.com/enso-org/enso/actions/runs/9610005652/job/26505582261?pr=10328#step:7:949 - why do we have the shall script at all?

Both issues shall be solved by 71b20a7

JaroslavTulach commented 1 week ago

The windows job has succeeded in 14min. The Mac OS X job succeeded as well but it took one hour. Obviously Linux job was successful in 23min. We could make these numbers lower by removing the NI+Espresso build - that one is highly experimental and needs only to be executed on a single platform.

Update after 1b0d22e that removed Espresso+NI check on Mac and Windows we get :

Linux runs for 23min (still with Espresso+NI check)
Mac finished in 46min
Windows tool 12min