Closed somebody1234 closed 4 days ago
@MrFlashAccount any ideas on what to do about the duplicate title bars for the settings modal?
maybe dialogs can accept React.ReactNode
as their title? not sure if that's ideal though
Can we show the close button only on tab hover?
Tab name and opening project might be out of sync:
Can we show a loader or something here? (and, finally, remove this ugly tooltip!)
Closing the tab doesn't trigger closing the project:
https://github.com/enso-org/enso/assets/61194245/e5c9c2a4-f686-4a5e-8779-c58f86ba0083
maybe dialogs can accept React.ReactNode as their title? not sure if that's ideal though
I'm fine with that, though we should be careful here because, from the ally and design perspective, we should have text title with "slot="title"" and make sure we're not breaking the UI much
Closing the tab doesn't trigger closing the project
oops, i had that fixed locally but forgot i didnt push it
Can we show a loader or something here? (and, finally, remove this ugly tooltip!)
<Result status="loading" />
would be nice.
Ideally we might want to eventually refactor it to <Suspense />
and get offline support automatically(it will show offline message if we try to open a cloud project)
so the changes were bigger than expected due to the loader... i think the code right now is pretty janky but i think it works. feel free to add new commits as i'm done for the week if there's e.g. any obvious places to clean up
We decided to Omit the Settings
tab changes from the PR because apparently, we need to pay more attention to this change: refactor nested dialogs(they cause issues when we open/close them), also we need to add separate scrolling to the sidebar.
Other than that looks good to me
Pull Request Description
Important Notes
None
Screencast
https://github.com/enso-org/enso/assets/4046547/8ccf34ec-e469-433c-8875-83a968a84022
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Unit tests have been written where possible.