search

enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.3k stars 317 forks source link

After changing drop-down input variant, the drop-down is no longer displayed. #10338

Closed farmaazon closed 15 hours ago

farmaazon commented 1 week ago

To reproduce: place filter component, pick Equal for filter condition and pick <Number literal> as to argument. Then, change it to `. Click the text input - there should be drop-down opened, but it is not.

The cause is a bug in edit handler; when picking another widget input, the AST has new ID, but edit handler of WidgetSelection on this AST still has old port ID. Starting interaction in inner widget will make the parent (selection) widget start interaction with old ID, which will be immediately canceled because the child will start different interaction.

As a solution, I think WidgetEditHandler should be simplified, and not rely on any portId: just if any widget starts interaction, it should start interaction on top-level parent, canceling any existing interaction

enso-bot[bot] commented 3 days ago

Keziah Wesley reports a new STANDUP for today (2024-06-24):

Progress: Working on new WidgetEditHandler impementation. It should be finished by 2024-06-28.

Next Day: Next day I will be working on the #10338 task. Same task

enso-bot[bot] commented 2 days ago

Keziah Wesley reports a new STANDUP for yesterday (2024-06-25):

Progress: Finished main refactor. It should be finished by 2024-06-28.

Next Day: Next day I will be working on the #10338 task. Edited-value propagation; testing.

enso-bot[bot] commented 1 day ago

Keziah Wesley reports a new STANDUP for yesterday (2024-06-26):

Progress: Finished PR. Researched precedence change. It should be finished by 2024-06-28.

Next Day: Next day I will be working on the #10338 task. Next task.