enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.35k stars 323 forks source link

Fix getDocuments on Windows #10350

Closed 4e6 closed 3 months ago

4e6 commented 3 months ago

Pull Request Description

followup #10240

Changelog:

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

somebody1234 commented 3 months ago

what does this do btw? https://github.com/enso-org/enso/blob/40f23bd10f917a70639c8241c2d48c2f293b46b9/app/ide-desktop/lib/project-manager-shim/src/desktopEnvironment.ts#L79

somebody1234 commented 3 months ago

it looks kinda like a regex, but note that string literals are not regex literals (the docs for String.split may or may not be relevant?)

4e6 commented 3 months ago

it looks kinda like a regex

you are right. Thanks for pointing, I updated the logic