enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.35k stars 323 forks source link

Implement markdown link syntax and "follow link" popup. #10353

Closed Frizi closed 3 months ago

Frizi commented 3 months ago

Pull Request Description

Fixes #9907

Implements link support in the comment markdown editor. Supports both markdown-style links and auto-detection for raw URLs.

https://github.com/enso-org/enso/assets/919491/b38f860a-ee4a-41a8-b936-41e9ef1602b9

https://github.com/enso-org/enso/assets/919491/059beca2-7737-41a1-a136-31a42ef9ee48

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

Frizi commented 3 months ago

Yeah, we are now supporting arbitrary linking intentionally, therefore TRUSTED_EXTERNAL_HOSTS doesn't make much sense anymore.

kazcw commented 3 months ago

The bundling issue was fixed by removing PlainTextEditor's dependency on MarkdownEditor/formatting.ts.