Don't cache errored requests for /user/me endpoint - Githubissues

enso-org / enso

Hybrid visual and textual functional programming.

https://enso.org

Apache License 2.0

7.3k stars 317 forks source link

Don't cache errored requests for /user/me endpoint #10360

Closed MrFlashAccount closed 3 days ago

MrFlashAccount commented 3 days ago

Pull Request Description

Closes #10359

Also this PR changes the behavior of offline cache - we don't use it if user is online

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.

PabloBuchu commented 3 days ago

qa ✅ @MrFlashAccount lets try to merge it