enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.3k stars 317 forks source link

Enshure we cleanup ProjectManager before creating a new one #10373

Closed MrFlashAccount closed 1 day ago

MrFlashAccount commented 3 days ago

Pull Request Description

Tl;dr 

Closes: enso-org/cloud-v2#1325 This PR fixes a bug when we were creating multiple instalces of ProjectManager and didn't dispose it's resources after GC

Demo Presentation

// PUT VIDEO HERE


Context:

Few sentences on the high level context for the change. Link to relevant design docs or discussion.

This Change:

What this change does in the larger context. Specific details to highlight for review:

  1. Make project manager as an external dependency for LocalBackend
  2. Put creating ProjectManager inside ReactQuery

Test Plan:

Go over how you plan to test it. Your test plan should be more thorough the riskier the change is. For major changes, I like to describe how I E2E tested it and will monitor the rollout.


Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR: