enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.31k stars 317 forks source link

Fix importing `.enso-project` files #10379

Closed somebody1234 closed 5 days ago

somebody1234 commented 5 days ago

Pull Request Description

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

somebody1234 commented 5 days ago

pinging @MrFlashAccount for CR - the code isn't pretty but it works... but feedback would be appreciated

and @PabloBuchu for testing on macos and @jdunkerley for testing on windows? i could repro on linux (./enso.AppImage ~/path/to/thing.enso-project) which is where i tested

PabloBuchu commented 5 days ago
  1. When Enso opens can it open on local tab because thats the place where project is starting? Currently always starts with cloud
  2. Redirect to opened project is also not working. I see its spins for a while and then its ready (but I stay on dashboard)
  3. Are we able to rename it if there is project with the same name?
  4. Sometimes it spins indefinitely. Double click on a file then immediately switch to local or recent then check the project. It will stay loading
somebody1234 commented 5 days ago
  1. done (and simplified the code again)
  2. done as a side effect of the above
  3. TODO. will involve messing around with the code to import projects on the Electron side
  4. can't repro after changes made in (1) - didn't test before changes made in (1)
somebody1234 commented 5 days ago

@PabloBuchu (3) should also be addressed now

jdunkerley commented 5 days ago

Works on my Windows box again - thank you. We need to make it open in the same session if possible but thats a separate issue!