enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.31k stars 317 forks source link

Fix background color #10397

Closed somebody1234 closed 4 days ago

somebody1234 commented 4 days ago

Pull Request Description

Important Notes

None

Screenshots

Before: image

After: image

Search bar outline: image

Search bar outline in settings: image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

PabloBuchu commented 4 days ago

I am not an designer but wouldn't it be better to make Asset Panel the same colour as bg and just make a vertical line between dashboard and the panel to mark those are different zones. Right now it has a 3rd colour which doesn't occur anywhere else in dashboard. @MrFlashAccount wdyt?

Screenshot 2024-06-28 at 09 24 09
  1. With new Asset Panel color the Versions and Sessions buttons are invisible... the same when you want to update description.
  2. When you open panel it slides from the left nicely from the right.. When you close the content disappear and you see the blank panel slowly fading. How hard would it be to implement sliding to the right with content in it (so it looks like true side panel)?
MrFlashAccount commented 4 days ago

@PabloBuchu This panel needs a stronger shadow to match the current design, making it the same color isn't necessary

MrFlashAccount commented 4 days ago

Searchbar/User "cloud" should have #fff bg CleanShot 2024-06-28 at 10 45 27@2x

somebody1234 commented 4 days ago

Searchbar/User "cloud" should have #fff bg

not sure about this. i think it would be more consistent to switch to an outline to match with the assets table search bar. @MrFlashAccount thoughts?