Open somebody1234 opened 4 days ago
@MrFlashAccount here's the wip btw - based on the debug logs it seems like the clip-path
is getting set, and then it is immediately getting unset by a second ref containing null
, in a component that somehow has a reference to the same background element
on a side note, i've removed loaderPosition
from ariaComponents.Button
since i imagine it was only useful for tab buttons - the default behavior is probably what's best for all actual buttons
on a side note, i've removed loaderPosition from ariaComponents.Button since i imagine it was only useful for tab buttons - the default behavior is probably what's best for all actual buttons
This one is a good thing. I think we should probably keep it
Pull Request Description
Fix some React warnings:
button
s when close button is in tab buttonbutton
to a link without ahref
. It's not ideal but we still want to use the CSS that comes with buttons, we just can't have nestedbutton
elements in HTML.useEffect
when deciding to show Local category when user is not enabledisInvalid
prop to plain HTML element in ToS modalImportant Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Unit tests have been written where possible.