enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.31k stars 317 forks source link

Fix React warnings #10404

Open somebody1234 opened 4 days ago

somebody1234 commented 4 days ago

Pull Request Description

Fix some React warnings:

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

somebody1234 commented 1 day ago

@MrFlashAccount here's the wip btw - based on the debug logs it seems like the clip-path is getting set, and then it is immediately getting unset by a second ref containing null, in a component that somehow has a reference to the same background element

on a side note, i've removed loaderPosition from ariaComponents.Button since i imagine it was only useful for tab buttons - the default behavior is probably what's best for all actual buttons

MrFlashAccount commented 19 hours ago

on a side note, i've removed loaderPosition from ariaComponents.Button since i imagine it was only useful for tab buttons - the default behavior is probably what's best for all actual buttons

This one is a good thing. I think we should probably keep it