enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.36k stars 324 forks source link

Doc Panel Issues #10435

Closed jdunkerley closed 2 months ago

jdunkerley commented 3 months ago
### Tasks
- [x] Pasting Images
- [x] Numbered lists reset on re-opening
- [ ] https://github.com/enso-org/enso/issues/10678
- [x] Doc Panel does not save its position on close
- [x] Images don't appear until panel is closed and re-opened. Link appears on initial creation.
- [x] Doc panel resizing not working

Pasting Images

Numbered lists reset on re-opening

Documentation panel becomes unstable if there are emojis like šŸ—ļø or šŸ˜€ but not 1ļøāƒ£

If you add these to a doc panel, you can't delete them and the window becomes unstable. Can remove via VS Code, but that seems to mess up the placement of all components on the graph editor...

Doc Panel does not save its position on close

Images don't appear until panel is closed and re-opened. Link appears on initial creation.

Image

vitvakatu commented 2 months ago

Canā€™t reproduce ā€œDoc Panel does not save its position on closeā€ on the latest develop. Also, ā€œNumbered lists reset on re-openingā€ only happens in dev builds; I didnā€™t find a way to reproduce it with the Electron build.

ā€œImages don't appear until panel is closed and re-opened. Link appears on initial creation.ā€ ā€“Ā fixed, PR to be opened.

vitvakatu commented 2 months ago

Everything except for emojis was fixed, closing this task now, splitting emoji into a separate one.

enso-bot[bot] commented 1 month ago

Ilya Bogdanov reports a new STANDUP for the provided date (2024-07-16):

Progress: Investigating issue with live editing of images in doc panel. Found misconfiguration of the plugin. It should be finished by 2024-07-25.

enso-bot[bot] commented 1 month ago

Ilya Bogdanov reports a new STANDUP for the provided date (2024-07-17):

Progress: Learning how lexical markdown plugin works with images, can reliably reproduce the issue with pasting images from HTML. Fixing the bug, triggered circular dependency in our modules, spent a lot of time fixing it. It should be finished by 2024-07-25.

enso-bot[bot] commented 1 month ago

Ilya Bogdanov reports a new STANDUP for the provided date (2024-07-18):

Progress: Implemented a fix, opened a PR. Also fixed doc panel resizing in a separate PR. It should be finished by 2024-07-25.

enso-bot[bot] commented 1 month ago

Ilya Bogdanov reports a new STANDUP for the provided date (2024-07-19):

Progress: Investigating issue with numbered lists. Fixed another issue with images (live editing). It should be finished by 2024-07-25.

enso-bot[bot] commented 1 month ago

Ilya Bogdanov reports a new STANDUP for the provided date (2024-07-22):

Progress: Still investigating numbered lists, can reproduce it reliably, but not sure what causes it. Turned out it only happens on dev builds, so probably some issue with vue hot reloading. It should be finished by 2024-07-25.

enso-bot[bot] commented 1 month ago

Ilya Bogdanov reports a new STANDUP for the provided date (2024-07-23):

Progress: Investigating why emojis are not working in doc panel. They actually donā€™t work in code editor as well. It should be finished by 2024-07-25.

enso-bot[bot] commented 1 month ago

Ilya Bogdanov reports a new STANDUP for the provided date (2024-07-24):

Progress: Debugging emojis issue. Seems to be caused by editing AST, but not aparent issue in gui codebase. Debugging the engine side. It should be finished by 2024-07-25.

enso-bot[bot] commented 1 month ago

Ilya Bogdanov reports a new STANDUP for the provided date (2024-07-25):

Progress: Found a repro test case for emoji issue, seems like the engine does not handle certain unicode correctly when editing. Creating a separate issue. Also fixed extended menu button as part of task 10581. It should be finished by 2024-07-25.