search

enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.34k stars 320 forks source link

Unable to download from subfolders #10453

Closed somebody1234 closed 1 month ago

somebody1234 commented 2 months ago

However, it seems that it does not support specifying the parent directory, which seems to break download functionality in nested folders on develop.

somebody1234 commented 2 months ago

pinging @4e6 as the author of the original PR

somebody1234 commented 2 months ago

oh, apparently it's been assigned to hubert

hubertp commented 2 months ago

As per discussion in the standup, this is currently defined in https://github.com/enso-org/enso/blob/develop/lib/scala/project-manager/src/main/scala/org/enso/projectmanager/infrastructure/http/ProjectsEndpoint.scala#L41

GitHub
enso/lib/scala/project-manager/src/main/scala/org/enso/projectmanager/infrastructure/http/ProjectsEndpoint.scala at develop · enso-org/enso
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
enso-bot[bot] commented 1 month ago

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-08):

Progress: Investigating logic behind project endpoint. Draft PR in place. Continued investigating startup logs. It should be finished by 2024-07-09.

Next Day: Next day I will be working on the #10453 task. Continue profiling startup.

enso-bot[bot] commented 1 month ago

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-09):

Progress: Addressed review. Investigating regression in startup for #10503. Analyzed ongoing issues with cloud integration and filed #10495 as a blocker. It should be finished by 2024-07-09.

Next Day: Next day I will be working on the #10453 task. Continue profiling startup.

hubertp commented 1 month ago

@somebody1234 Can you check if the additional parameter unblocks you?

somebody1234 commented 1 month ago

@hubertp funny thing is, i was testing exactly this today and i can't get it to work on the latest nightly. code is here: https://github.com/enso-org/enso/tree/wip/sb/dashboard-fixes - to test, download from subfolder on electron. you should be able to run npm run watch:linux (or macos/windows) in app/ide-desktop/lib/client to test electron without having to build the entire app

GitHub
GitHub - enso-org/enso at wip/sb/dashboard-fixes
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
somebody1234 commented 1 month ago

but yeah theoretically the additional parameter is enough

hubertp commented 1 month ago

Confirmed that this now works. I was working on an outdated branch where GUI wasn't passing the full url (the projectsDirectory parameter was missing).

enso-bot[bot] commented 1 month ago

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-23):

Progress: Applying Jaroslav's change to #10440. Got stuck on some native image build problems. Trying to debug #10453 - somehow backend is not receiving projectsDirectory parameter. Continued debugging Windows problems. #10453 was blocked on GUI support, hence the delay. It should be finished by 2024-07-24.

Next Day: Next day I will be working on the #10453 task. Continue investigating the issue.

enso-bot[bot] commented 1 month ago

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-24):

Progress: Found out that I was working on an outdated branch in GUI which fixed the problem with missing query. Solved native image build problems with Jaroslav for #10440, it's now ready for testing. Verified a fix for #10588. Started looking into #10662. It should be finished by 2024-07-24.

Next Day: Next day I will be working on the #10662 task. Continue investigating the issue.