enso-org / enso

Hybrid visual and textual functional programming.

https://enso.org

Apache License 2.0

7.32k stars 320 forks source link

Decimal tweaks #10480

Closed GregoryTravis closed 1 day ago

GregoryTravis commented 2 weeks ago

[x] Rename Decimal.from_string to Decimal.from_text.
[x] Add a dec function to top level namespace
[x] Integers are automatically converted to decimals when used in decimal operations
~~[ ] Arithmetic Decimal operations between a decimal and a float should throw an error~~
[x] Should promote the float to a decimal and attach a warning (saying best to use decimals
[x] Comparison Perform the comparison between the decimal and the float; Attach same warning as equality.

enso-bot[bot] commented 2 weeks ago

Greg Travis reports a new STANDUP for today (2024-07-08):

Progress: updating Decimal behavior according to JD+AR’s new decisions; now trying to make f+d mixed operations an error It should be finished by 2024-07-15.

Next Day: test failures

enso-bot[bot] commented 2 weeks ago

Greg Travis reports a new STANDUP for today (2024-07-09):

Progress: removed float/decimal conversion, fixing tests from that, and adding extra info for float/decimal mixed operation errors It should be finished by 2024-07-15.

Next Day: conversions

GregoryTravis commented 1 week ago

10517 does not implement errors for mixed float/decimal arithmetic. There are a few options, none of them acceptable yet:

Keeping from conversions between Float and Decimal means that Floats are promoted to Decimal transparently for all arithmetic operations, making it impossible to throw an error in these cases (without undesirable special cases engine hacks).
Removing from conversions means that equality between Floats and Decimals cannot be accomplished (without undesirable special cases engine hacks), since equality is implemented as a builtin and only uses EqualsSimpleNode and from comparisons.
Promoting warnings to errors in arithmetic operations would surely make them much slower.

enso-bot[bot] commented 1 week ago

Greg Travis reports a new STANDUP for today (2024-07-10):

Progress: completed Decimal usability tweaks (except errors); attempted to implement errors, documented results It should be finished by 2024-07-15.

Next Day: equality errors? otherwise other small decimal fixes

enso-bot[bot] commented 1 week ago

Greg Travis reports a new STANDUP for today (2024-07-11):

Progress: finished first tweaks; tracking down a non-reproducible bug about interop for EnsoObject It should be finished by 2024-07-15.

Next Day: bug; comparisons

enso-bot[bot] commented 1 week ago

Greg Travis reports a new STANDUP for today (2024-07-15):

Progress: spent all day tracking down warning-related bug caused by using a checked return type. Continuing to work on decimal mixed comparisons. It should be finished by 2024-07-16.

Next Day: bug; comparisons

enso-bot[bot] commented 1 week ago

Greg Travis reports a new STANDUP for today (2024-07-16):

Progress: mixed decimal comparisons, getting tests to pass; why (again) can I not run the front end? It should be finished by 2024-07-17.

Next Day: bug; comparisons

GregoryTravis commented 1 day ago

Closing, as I've moved the error task to #10631