enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.35k stars 321 forks source link

Unify scripts for dashboard and GUI. #10668

Open farmaazon opened 1 month ago

farmaazon commented 1 month ago

Now we have two vite configurations and thus two ways of building dev server (and everything else). This task is to unify the configuration (both vite.config and package.json) and stay with a single dev server, run in browser.

In this task also the relation between dashboard and GUI should be simplified: the dashboard should just have GUI as a dependency, and GUI part should not maintain any entry point invoking dashboard.

To consider: having both dashboard and current GUI in a single app subdir (ide-desktop being purely electron).

somebody1234 commented 1 month ago

having both dashboard and current GUI in a single app subdir

not sure whether this makes sense - the codebases are still significantly different (different frameworks, different architecture an the like) - and idk if there's any advantage in having a more nested structure in this case (two directories in app/ vs one directory isn't a huge ifference IMO)

somebody1234 commented 1 month ago

other things to note:

farmaazon commented 1 month ago

not sure whether this makes sense - the codebases are still significantly different (different frameworks, different architecture an the like) - and idk if there's any advantage in having a more nested structure in this case (two directories in app/ vs one directory isn't a huge ifference IMO)

The advantage is that it's more intuitively reflects the relation between different components. Also, we said about "having a single vite config" and for me it's more natural that vite config handler all things in its subdir.

farmaazon commented 1 week ago

Refinement notes: