Unify scripts for dashboard and GUI.

enso-org / enso

Enso Analytics is a self-service data prep and analysis platform designed for data teams.

https://ensoanalytics.com

Apache License 2.0

7.36k stars 323 forks source link

Unify scripts for dashboard and GUI. #10668

Closed farmaazon closed 3 weeks ago

farmaazon commented 3 months ago

Now we have two vite configurations and thus two ways of building dev server (and everything else). This task is to unify the configuration (both vite.config and package.json) and stay with a single dev server, run in browser.

In this task also the relation between dashboard and GUI should be simplified: the dashboard should just have GUI as a dependency, and GUI part should not maintain any entry point invoking dashboard.

To consider: having both dashboard and current GUI in a single app subdir (ide-desktop being purely electron).

somebody1234 commented 3 months ago

having both dashboard and current GUI in a single app subdir

not sure whether this makes sense - the codebases are still significantly different (different frameworks, different architecture an the like) - and idk if there's any advantage in having a more nested structure in this case (two directories in app/ vs one directory isn't a huge ifference IMO)

somebody1234 commented 3 months ago

other things to note:

GUI's vite script is more comprehensive, the dashboard one doesn't include the GUI
- nor does it include HMR for vue, whereas GUI's vite script includes React HMR
we still want two ways to run the code - one for simulating the Electron app with local backend support, another for simulating cloud.enso.org with no local backend support

farmaazon commented 3 months ago

not sure whether this makes sense - the codebases are still significantly different (different frameworks, different architecture an the like) - and idk if there's any advantage in having a more nested structure in this case (two directories in app/ vs one directory isn't a huge ifference IMO)

The advantage is that it's more intuitively reflects the relation between different components. Also, we said about "having a single vite config" and for me it's more natural that vite config handler all things in its subdir.

farmaazon commented 2 months ago

Refinement notes:

on this occasion, consider renaming app to packages - we want to put there also everything from lib

farmaazon commented 1 month ago

Refinement notes:

lib/js/runner - to be removed.
eslint config also is to be unified: apply dashboard rules to GUI's code and see what rules are violated.
Renames:
- gui2 -> project-view.
- the main entry point: gui

enso-bot[bot] commented 1 month ago

Adam Obuchowicz reports a new STANDUP for yesterday (2024-10-03):

Progress: Started merging directories. Created new structure and merged package.json configurations (and some others). It should be finished by 2024-10-14.

Next Day: Next day I will be working on the same task. Continue fixing issues: with packaging, dev server, lint...

enso-bot[bot] commented 1 month ago

Adam Obuchowicz reports a new STANDUP for today (2024-10-04):

Progress: Tried to fix eslint config, with moderate success (we skipped GUI config for vue). Fixed dev server and package building - it works now! started merging playwright configs for tests. It should be finished by 2024-10-14.

Next Day: Next day I will be working on the same task. finish playwright and discuss eslint config.

enso-bot[bot] commented 4 weeks ago

Adam Obuchowicz reports a new STANDUP for the provided date (2024-10-07):

Progress: Fixed playwright configuration. It recognizes now all tests, but the dashboard's are mostly failing. Also moved sligthtly the column reordering. It should be finished by 2024-10-14.

Next Day: Next day I will be working on the same task. Fix dashboard tests and start fixing linter configuration.

enso-bot[bot] commented 3 weeks ago

Adam Obuchowicz reports a new STANDUP for the last Wednesday (2024-10-09):

Progress: Fixed most of the issues with linter - some checks are disabled because fixing them would take too long time. It should be finished by 2024-10-14.

Next Day: Next day I will be working on the same task. When testing CI jobs, discovered some problems with typecheck in ide-desktop/client package.

enso-bot[bot] commented 3 weeks ago

Adam Obuchowicz reports a new STANDUP for yesterday (2024-10-10):

Progress: Fixed the problem in ide-desktop/client. It had a dependency to gui (as formerly it had to dashboard), but it caused problem with project-view codebase. Discovered that it used only one type, so I moved this type to common package. Re-run all checks again, and discovered a regression in E2E tests. It should be finished by 2024-10-14.

Next Day: Next day I will be working on the same task. When E-Hern fix e2e tests, I think only last touches remain.

enso-bot[bot] commented 3 weeks ago

Adam Obuchowicz reports a new STANDUP for today (2024-10-11):

Progress: Last touches. Debugged another package failure (caught by integration tests!) and then stabilize e2e tests (again) - they failed in CI. Also, the flacky test in GUI became very flaky, so I investigated the problem there. The PR is waiting for merge It should be finished by 2024-10-14.

Next Day: Next day I will be working on the #10759 task. Go back to reordering columns in Table Input; investigate the issue.