Update `Enso_File` download to Cloud API changes, fix missing Cloud tests

radeusgd commented 1 week ago

As asked for by @PabloBuchu, related to https://github.com/enso-org/cloud-v2/pull/1580/
Fixes nightly Extra tests:
- Ensures that the Cloud suite is actually ran
- Enables logging of all tests and the Test Report on the nightly to make it possible to inspect what was being run.

Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.
[x] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries, or the Snowflake database integration, a run of the Extra Tests has been scheduled.
- If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

radeusgd commented 1 week ago

Enso_File_Spec tests are passing so it should be all good. Not sure if worth running Cloud tests on CI as they are failing on develop anyway.

radeusgd commented 2 days ago

Trying 2 new approaches to listing ran tests (as I noticed some broken tests even though green status on develop).

Re-enable listing all tests in CI log on the Extra workflow. a. I think there it is useful to see all tests that were run. Failures can be quickly glanced over thanks to recently added annotations.
Trying to enable the Test Report workflow a. It was disabled due to a 'not a fork' check, but that was also affecting scheduled and dispatched runs which I don't think was right.

✅ https://github.com/enso-org/enso/actions/runs/12036349017 - this run confirms that most "Cloud" tests are not being run... Some Cloud test cases are run in AWS and Table, but the main suite in Base seems to not be run for some reason...
❌ https://github.com/enso-org/enso/actions/runs/12048016976 - workflow failed successfully - we can see that the Cloud tests are finally being run! We get the expected failures from the minor regressions that we got in the tests. That's good.
✅ https://github.com/enso-org/enso/actions/runs/12049658850 - after the tests have been fixed, Extra tests are passing

radeusgd commented 1 day ago

Extra Cloud tests are now running the necessary Cloud tests, and they are passing 🎉

So I'm merging.

enso-org / enso