Open JaroslavTulach opened 5 days ago
Idea for increasing test coverage of EnsoMultiValue
: Manually create some Truffle nodes and explicitly call them. Inspiration from EqualsTest and HashCodeTest.
Idea for increasing test coverage of
EnsoMultiValue
: Manually create some Truffle nodes and explicitly call them. Inspiration from EqualsTest and HashCodeTest.
Pull Request Description
1st attempt to implement the
-> Complex
check. The idea is to split the list oftypes[]
inEnsoMultiValue
into two parts:dispatchMethodTypes
represent the types the value has been cast toBy performing this separation I hope to address the #10882. After a type check only methods available on the
dispatchMethodTypes
can be invoked. However the value can still be cast to all the possible types.Important Notes
@Akirathan, @radeusgd please check the idea, feel free to contribute new test cases. The goal of this PR is to get the dispatch/cast logic right. The next step would be to make it fast. So far some tests are failing, but the ideas in this PR shall already be eligible for a review.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR: