Fix runtime-instrument-common benchmark

enso-org / enso

Enso Analytics is a self-service data prep and analysis platform designed for data teams.

https://ensoanalytics.com

Apache License 2.0

7.39k stars 323 forks source link

Fix runtime-instrument-common benchmark #11619

Closed 4e6 closed 3 days ago

4e6 commented 3 days ago

Pull Request Description

Fix the runtime-instrument-common benchmark compilation.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] Unit tests have been written where possible.

4e6 commented 3 days ago

I didn't know that it was not used. I thought it was silently failing on CI or smth. I'd rather remove it then

Akirathan commented 3 days ago

I didn't know that it was not used. I thought it was silently failing on CI or smth. I'd rather remove it then

@4e6 It is not used anywhere, it is not tested anywhere, we don't observe the results ever. Therefore, I consider it useless. If it is not worth putting into runtime-benchmarks, I would rather remove it altogether.

PS: If you decide to remove it, please ensure that you also remove the runtime-instruments-common/Bench configuration from sbt. Let's simplify as many things as possible.

JaroslavTulach commented 3 days ago

This benchmark is supposed to measure speed of the RuntimeCache. The intention is good (measuring something like that would be good), but the realization is just too "naive".

btw. #5027

Really useful benchmark would compare running the same Enso code with and without instrumentation as done by language server.