Visualization should be loaded on demand

enso-org / enso

Hybrid visual and textual functional programming.

https://ensoanalytics.com

Apache License 2.0

7.36k stars 324 forks source link

Visualization should be loaded on demand #2629

Closed wdanilo closed 2 years ago

wdanilo commented 3 years ago

General Summary

Currently, visualizations are loaded on GUI start which akes the whole GUI start time very long, even up to 7 seconds. The majority of it (up to 6s) is because of visualizations which load all dependencies etc.

Expected Result

Visualizations should be loaded and initialized when needed - when a particular visualization is opened. It should be done by making a special asynchronious JS function to load deps of visualization and handling it properly in Rust.

MichaelMauderer commented 3 years ago

I believe this is a duplicate of https://github.com/enso-org/ide/issues/985

farmaazon commented 3 years ago

Hmm, for me it seems like "the first step" of enso-org/enso#2591 which contains two things:

Loading visualization on demand, on during init
Managing dependencies to not duplicate them (like d3js libraries).

farmaazon commented 3 years ago

BR:

We need asset manager. Visualization can say the manager what assets are required. After all require assets are loaded, the visualization should be shown.
The required assets for visualization should be downloaded once the vis is brought into the view (with space for instance), not when it receives the data first time.
The visualization should be attached in Engine before all the assets will be loaded. If visualization will receive data before assets are loaded, the data shall be buffered.

farmaazon commented 3 years ago

@sylwiabr: To check during refinement, if estimate was accurate.