enso-org / enso

Enso Analytics is a self-service data prep and analysis platform designed for data teams.
https://ensoanalytics.com
Apache License 2.0
7.39k stars 323 forks source link

Share code between engine and stdlib #5259

Open wdanilo opened 1 year ago

wdanilo commented 1 year ago

This task is automatically imported from the old Task Issue Board and it was originally created by Pavel Marek. Original issue is here.


As pointed out in this comment, we should investigate how (and if) to share code between engine and std libs. Now, this includes something from std-bits/base

Maybe introduce a library that is independent of engine and provides some specialization for primitives?

Some examples where std-bits duplicate functionality from the engine:

Tasks:

Comments:

As pointed out in this comment, we should investigate how (and if) to share code between engine and std libs. Now, this includes something from std-bits/base (Pavel Marek - Dec 20, 2022)


radeusgd commented 1 year ago

Parts of this were done as #5855 - this gives us the shared library which allows for having common code used both on engine and polyglot libraries side.

However, we still need to ensure that the hashing and object comparison/equality mechanism used in the in-memory Table library is delegating to the same code that the engine uses - so that we can avoid code duplication which may lead to potential inconsistency.

The places to look at in particular (not necessarily an exhaustive list):

radeusgd commented 1 year ago

cc: @Akirathan as you may be interested in this :)