enso-org / enso

Enso Analytics is a self-service data prep and analysis platform designed for data teams.
https://ensoanalytics.com
Apache License 2.0
7.36k stars 323 forks source link

Generate completion of `Table.join` join criteria using data from both joined tables #5629

Closed Frizi closed 6 months ago

Frizi commented 1 year ago

Currently the completion forTable.join on parameter only takes the left-side table columns into account.

image

Ideally we want to compute the widget entries using column names from both tables. That requires new IDE and engine capabilities:

Acceptance criteria:

Table.join method on widget completion allows selecting join criteria using column names from both tables.

jdunkerley commented 1 year ago

As part of the JS Vue IDE work the ability to do this must be considered.

Frizi commented 1 year ago

So far, the limitation for this issue has been on the protocol level, not on UI. The discussion on it was started, but without any response yet https://github.com/orgs/enso-org/discussions/6832

GitHub
Widget Visualizations with multiple input expressions 路 enso-org 路 Discussion #6832
Currently, the data for dynamic node widgets is requested using language server's Visualization API. That allows us to resolve method annotations using the data from evaluated method call's target....
JaroslavTulach commented 8 months ago

Trying to recollect my previous thoughts and work on this topic reminds me of

Take a look at * instead of + test to see that there already is a way for an Enso code (including visualization code - I hope) to observe not only self, but also other arguments when a call is made. E.g. once one:

All that is needed (from my point of view) is to design an experiment to use this mechanism in the IDE. What one needs to do on the IDE side to invoke the instrumenter, @Frizi? How are the visualizations done in the GUI2?

enso-bot[bot] commented 8 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-11):

Progress: - prototypingTable.join

Next Day: PoC for Table.join

Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
GitHub
Use .. to identify autoscoped constructors by JaroslavTulach 路 Pull Request #9285 路 enso-org/enso
Pull Request Description Fixes #9275. Checklist Please ensure that the following checklist has been satisfied before submitting the PR: The documentation has been updated, if necessary. All code...
enso-bot[bot] commented 7 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-12):

Progress: - Table.join prototyping - IDE sends more data

Next Day: Extract UUIDs for arguments in visualization

Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
enso-bot[bot] commented 7 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-13):

Progress: - discussing WASM in y.js: https://discord.com/channels/@me/968956156758343744/1217509898414325900

Next Day: Use UUIDs from arguments in visualization

Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
enso-bot[bot] commented 7 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-14):

Progress: - Poc of Table.join: https://github.com/enso-org/enso/pull/9410

Next Day: Debugging & bugfixing

enso-bot[bot] commented 7 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-15):

Progress: - better foreign js debugging and coloring: https://github.com/enso-org/enso/pull/9440

Next Day: Instrumentation of autoscoped constructors

enso-bot[bot] commented 7 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-18):

Progress: - debuggging autoscoped constructors

Next Day: Finish onstrumentation of autoscoped constructors

enso-bot[bot] commented 7 months ago

Jaroslav Tulach reports a new 馃敶 DELAY for yesterday (2024-04-10):

Summary: There is 30 days delay in implementation of the Generate completion of Table.join join criteria using data from both joined tables (#5629) task. It will cause 30 days delay for the delivery of this weekly plan.

Table.join is complicated

Delay Cause: After prototyping, I was working on something else

Possible solutions: Focus, focus, focus!

enso-bot[bot] commented 7 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-10):

Progress: - reviews

enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-11):

Progress: - fighting with typescript: https://github.com/enso-org/enso/pull/9410#discussion_r1560898613

enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-12):

Progress: - working on Table.join: https://github.com/enso-org/enso/pull/9410/commits/81aa2160c99a8a0ba3484f167a3c917e0190981a

enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for the last Saturday (2024-04-13):

Progress: - describing status of Table.join: https://github.com/orgs/enso-org/discussions/9695#discussioncomment-9101924

GitHub
[2024-04-15] Library & Engine Team Update 路 enso-org 路 Discussion #9695
Rados艂aw: Refactoring Enso_File to be path based #9581 Rados艂aw: Improve handling of File.parent and File.name #9642 Rados艂aw: Make HTTP tests more robust by adding retries to the tests #9652 Rados...
enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-15):

Progress: - reviewing Table.join PoC with Dmitry

enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-16):

Progress: - get_widget_json method with uuids arg: https://github.com/enso-org/enso/pull/9410#discussion_r1566871611

GitHub
enso/app/gui2/src/util/database/reactiveDb.ts at dff1c0c88ba09fdf18cfcf85e5c1f1d286c72512 路 enso-org/enso
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
Vue.js
Vue.js - The Progressive JavaScript Framework
enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-17):

Progress: - thinking about caching: https://github.com/enso-org/enso/blob/fda41cbfd1d1966d8772d1a889905b78651e734e/docs/runtime/caching.md

GitHub
enso/docs/runtime/caching.md at fda41cbfd1d1966d8772d1a889905b78651e734e 路 enso-org/enso
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new 馃敶 DELAY for yesterday (2024-04-18):

Summary: There is 6 days delay in implementation of the Generate completion of Table.join join criteria using data from both joined tables (#5629) task. It will cause 6 days delay for the delivery of this weekly plan.

Delay Cause: functionality is working and is being reviewed, but it needs to be polished and tests written

Possible solutions: Let's plan to integrate by next Tuesday

enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-18):

Progress: - 2 == 2.0 - https://github.com/enso-org/enso/issues/9607#issuecomment-2063012560

enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-19):

Progress: - fixing 2^63: https://github.com/enso-org/enso/pull/9740#discussion_r1571873477

Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
Discord
Discord - A New Way to Chat with Friends & Communities
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for the last Saturday (2024-04-20):

Progress: - evaluating benchmarks: https://github.com/enso-org/enso/pull/9746#issuecomment-2067563304

enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-22):

Progress: - Table.join needs final review: https://github.com/enso-org/enso/pull/9410

enso-bot[bot] commented 6 months ago

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-23):

Progress: - Got review for Table.join: https://github.com/enso-org/enso/pull/9410