21 compiler tests that relied on the old parser disabled

[kazcw]

Some backend tests that had not been switched to the new parser before #5917 don't pass with the new parser; these can be found by searching the codebase for references to this issue number (after that PR merges).

This is due to syntax cases that don't occur outside the tests in question, and that generally relate to type signatures and type declarations.

Each test either needs to be updated or needs a (generally simple) change in translation or the parser.

[JaroslavTulach]

There seems to be 21 such tests right now:

enso$ grep -r 5894 engine/runtime/src/test/
engine/runtime/src/test/scala/org/enso/compiler/test/pass/desugar/LambdaShorthandToLambdaTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/desugar/FunctionBindingTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/desugar/ComplexTypeTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/IgnoredBindingsTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/ExpressionAnnotationsTest.scala:    // FIXME: New parser handles the syntax error differently--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/TypeSignaturesTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/TypeSignaturesTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SuspendedArgumentsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SuspendedArgumentsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/AliasAnalysisTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala:      // FIXME: Different result in new parser!--needs triage (#5894).

CCing @hubertp

[enso-bot[bot]]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-03-30):

Progress: - PR: https://github.com/enso-org/enso/pull/6143

• Meeting James & standup
• Book Club: Never played a Scrabble: https://discord.com/channels/401396655599124480/1090224103971106816/1090965170081234964
• lazy atom fields (#6134) PR: https://github.com/enso-org/enso/pull/6151 It should be finished by 2023-04-03.

Next Day: Continue analyzing disabled parser tests.

Discord

Discord - A New Way to Chat with Friends & Communities

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

[enso-bot[bot]]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-03-31):

Progress: - Review: https://github.com/enso-org/enso/pull/6154

• Addressing comments in https://github.com/enso-org/enso/pull/6143
• 360 deg feedback & standups It should be finished by 2023-04-03.

Next Day: Continue analyzing disabled parser tests.

[enso-bot[bot]]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-01):

Progress: - parser tests - got SuspendedArgumentsTest working: https://github.com/enso-org/enso/pull/6143/commits/0dbe6369942d529a1e784ff0d49ecbca0864a66f

• parser tests: https://github.com/enso-org/enso/pull/6143/commits/487620f5bf04b384744f13ede1dacc7876296f9f
• TypeSignaturesTest fixed
• EnsoProject bugfix: https://github.com/enso-org/enso/pull/6149/commits/143384778aaafbf28c943a0cfd012c19c21c6fb5 It should be finished by 2023-04-03.

Next Day: BookClub.