enso-org / enso

Hybrid visual and textual functional programming.
https://enso.org
Apache License 2.0
7.34k stars 320 forks source link

Edited node wiggles when panning the scene on non-default zoom level #6456

Closed vitvakatu closed 6 months ago

vitvakatu commented 1 year ago

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

Is this a regression?

What issue are you facing?

https://user-images.githubusercontent.com/6566674/234887288-dae20803-4309-4280-8c9b-0f3235571cd1.mp4

I have been spotting this issue for some time. It probably does not make sense to bisect it. The issue is probably in the algorithm for the searcher camera position updates.

Expected behaviour

The edited node must be aligned to the CB.

How we can reproduce it?

No response

Screenshots or screencasts

No response

Enso Version

0c7c3bdeaf914c74e8d8af02c482454a1b01f8a8

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response

farmaazon commented 1 year ago

Reproduced on 7e333000130ea539fe82d5f5942f23047c92fe3a

kazcw commented 1 year ago

The cameras are updated asynchronously via the FRP batch mechanism. It is supposed to finish before anything observes it, but it was the cause of one bug I just fixed so it'd be a direction to look in to

farmaazon commented 6 months ago

No longer an issue in GUI2