Missing icon in standalone Enso

[hubertp]

Discord username

No response

What type of issue is this?

Transient – Occurring only once

Is this issue blocking you from using Enso?

• [ ] Yes, I can't use Enso because of this issue.

Is this a regression?

• [ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?

Built locally with ./run ide but I guess that shouldn't matter much.

Expected behaviour

App should be packaged with the right icon.

How we can reproduce it?

No response

Screenshots or screencasts

No response

Enso Version

efe904cd9f0c44c112a254229d94522802c246e5

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

Linux

Operating System Version

No response

Hardware you are using

No response

[4e6]

I remember it was working previously (for pre-built packages). The electron-builder-config provides icns file with the icon https://github.com/enso-org/enso/blob/6b0c682b08b7745368cec3474cc774c51a5b48f5/app/ide-desktop/lib/client/electron-builder-config.ts#L120

The icon size may be an issue https://www.electron.build/icons.html

icon.icns (macOS app icon) or icon.png. Icon size should be at least 512x512.

I can see that on Linux the icon has 64x64 resolution

$ file (readlink enso.png)
usr/share/icons/hicolor/32x32/apps/enso.png: PNG image data, 64 x 64, 8-bit/color RGBA, non-interlaced

I'm not sure how to check the icns file on macOS.

@hubertp did it work for you previously, e.g. when you install nightlies, or you have never seen the Enso icon? Did you use ./run ide build or ./run ide start command?

@mwu-tow can it be the case that the local ./run ide execution does not fetch the icon file?

Icons - electron-builder

[hubertp]

I believe it used to work for me and I had the icon correctly (so sounds like a regression). I just tried with the latest nightly (via AppImage) and it shows the same thing as when built locally, making the bug rather high priority.

Locally I built using ./run ide start.

[mwu-tow]

@mwu-tow can it be the case that the local ./run ide execution does not fetch the icon file?

I don't think so, icon is generated locally. I'd expect that if it was missing, the electron-builder should raise an error (though I don't know for sure).

@hubertp

Locally I built using ./run ide start.

This won't give you an icon. The ide start does not packages the Electron application but just runs it using the development mode, so no package is being created and no icon will be present.

[hubertp]

@mwu-tow can it be the case that the local ./run ide execution does not fetch the icon file?

I don't think so, icon is generated locally. I'd expect that if it was missing, the electron-builder should raise an error (though I don't know for sure).

@hubertp

Locally I built using ./run ide start.

This won't give you an icon. The ide start does not packages the Electron application but just runs it using the development mode, so no package is being created and no icon will be present.

OK, but executing via AppImage it should work, right?

[mwu-tow]

@mwu-tow can it be the case that the local ./run ide execution does not fetch the icon file?

I don't think so, icon is generated locally. I'd expect that if it was missing, the electron-builder should raise an error (though I don't know for sure).

@hubertp

Locally I built using ./run ide start.

This won't give you an icon. The ide start does not packages the Electron application but just runs it using the development mode, so no package is being created and no icon will be present.

OK, but executing via AppImage it should work, right?

Yes, it should work.

[wdanilo]

I believe that our icon generation scripts fail if they can't generate icons. The electron builder should fail as well ... This is strange. I understand it did not happen with other packages? If so, I'd close it for now and re-open if it happens again.